Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix build error on MacOS #852

Merged
merged 1 commit into from
Mar 25, 2018
Merged

bugfix build error on MacOS #852

merged 1 commit into from
Mar 25, 2018

Conversation

hqwrong
Copy link

@hqwrong hqwrong commented Mar 22, 2018 •
edited by iphydf
Loading

this pr fix the error when make on macosx:

mkdir _builds && cd _builds
cmake ..
make

get

ld: unknown option: -z
clang: error: linker command failed with exit code 1 (use -v to see invocation)

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Mar 22, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Mar 22, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.5%) to 76.272% when pulling eb6b602 on hqwrong:master into 9706d9a on TokTok:master.

@hqwrong hqwrong force-pushed the master branch 2 times, most recently from 2ddc1e4 to dcb13f5 Compare March 22, 2018 09:33
@sudden6
Copy link

sudden6 commented Mar 24, 2018

:lgtm_strong:

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

@iphydf iphydf merged commit eb6b602 into TokTok:master Mar 25, 2018
@iphydf iphydf added this to the v0.2.2 milestone Jun 25, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2.2
Development

Successfully merging this pull request may close these issues.
5 participants
@hqwrong @CLAassistant @coveralls @sudden6 @iphydf