Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow stderr logger by default. #846

Merged
merged 2 commits into from
Mar 18, 2018
Merged

Disallow stderr logger by default. #846

merged 2 commits into from
Mar 18, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Mar 17, 2018 •
edited
Loading

This change is Reviewable

@iphydf iphydf added this to the v0.2.2 milestone Mar 17, 2018
@sudden6
Copy link

sudden6 commented Mar 17, 2018

:lgtm_strong:

Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@iphydf iphydf closed this Mar 18, 2018
@iphydf iphydf deleted the explicit-stderr-logger branch March 18, 2018 04:57
@iphydf iphydf merged commit 9706d9a into TokTok:master Mar 18, 2018
@nurupo
Copy link
Member

nurupo commented Apr 8, 2018

@iphydf forgot to add USE_STDERR_LOGGER to INSTALL.md.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sudden6 sudden6

Labels
None yet
Projects
None yet
Milestone
v0.2.2
Development

Successfully merging this pull request may close these issues.
4 participants
@iphydf @sudden6 @nurupo @sum01