Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add COVERAGE cmake flag for clang. #844

Merged
merged 1 commit into from
Mar 17, 2018
Merged

Add COVERAGE cmake flag for clang. #844

merged 1 commit into from
Mar 17, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Mar 17, 2018

This only works with clang/llvm. Coveralls support needs to be added later.


This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Mar 17, 2018
@iphydf iphydf force-pushed the coverage branch 2 times, most recently from 245e25e to 52820c8 Compare March 17, 2018 04:57
@iphydf iphydf modified the milestones: v0.2.x, v0.2.2 Mar 17, 2018
@robinlinden
Copy link
Member

:lgtm_strong:


Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

This only works with clang/llvm. Coveralls support needs to be added later.
@iphydf iphydf merged commit ea7ecd6 into TokTok:master Mar 17, 2018
@iphydf iphydf deleted the coverage branch March 17, 2018 15:04
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants