Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make group number in the toxav public API uint32_t #800

Merged
merged 1 commit into from
Feb 20, 2018

Conversation

sudden6
Copy link

@sudden6 sudden6 commented Feb 19, 2018

fixes #606


This change is Reviewable

@iphydf iphydf changed the title make groupnumber uint32_t Make group number in the toxav public API uint32_t Feb 19, 2018
@sudden6 sudden6 force-pushed the fix_groupnumber branch 3 times, most recently from dc1793c to 15a71bd Compare February 19, 2018 21:25
@iphydf
Copy link
Member

iphydf commented Feb 20, 2018

Reviewed 8 of 8 files at r1.
Review status: all files reviewed at latest revision, 7 unresolved discussions, some commit checks failed.


toxav/groupav.c, line 431 at r1 (raw file):

static int groupchat_enable_av(Logger *log, Group_Chats *g_c, uint32_t groupnumber, void (*audio_callback)(Messenger *,
                               uint32_t,
                               uint32_t, const int16_t *, unsigned int, uint8_t, uint32_t, void *), void *userdata)

Formatting.


toxav/groupav.c, line 458 at r1 (raw file):

int add_av_groupchat(Logger *log, Group_Chats *g_c, void (*audio_callback)(Messenger *, uint32_t, uint32_t,
                     const int16_t *,
                     unsigned int,

Formatting.


toxav/toxav.h, line 748 at r1 (raw file):

 */
int toxav_add_av_groupchat(Tox *tox, void (*audio_callback)(void *, uint32_t, uint32_t, const int16_t *, unsigned int,
                           uint8_t,

Formatting?


toxav/toxav.h, line 762 at r1 (raw file):

 */
int toxav_join_av_groupchat(Tox *tox, uint32_t friendnumber, const uint8_t *data, uint16_t length,
                            void (*audio_callback)(void *, uint32_t, uint32_t, const int16_t *, unsigned int, uint8_t, uint32_t, void *),

Formatting.


toxcore/group.c, line 1117 at r1 (raw file):

 */
void group_lossy_packet_registerhandler(Group_Chats *g_c, uint8_t byte, int (*function)(void *, uint32_t, uint32_t,
                                        void *,

Formatting.


toxcore/group.h, line 299 at r1 (raw file):

 */
void group_lossy_packet_registerhandler(Group_Chats *g_c, uint8_t byte, int (*function)(void *, uint32_t, uint32_t,
                                        void *,

Formatting.


toxcore/tox.c, line 1110 at r1 (raw file):

    Messenger *m = tox;
    g_callback_group_namelistchange((Group_Chats *)m->conferences_object, (void (*)(struct Messenger *, uint32_t, uint32_t,
                                    uint8_t,

Formatting.


Comments from Reviewable

@iphydf
Copy link
Member

iphydf commented Feb 20, 2018

:lgtm_strong: other than formatting issues.


Review status: all files reviewed at latest revision, 7 unresolved discussions, some commit checks failed.


Comments from Reviewable

@iphydf iphydf added this to the v0.2.0 milestone Feb 20, 2018
@sudden6 sudden6 removed their assignment Feb 20, 2018
@sudden6 sudden6 merged commit 03b55cd into TokTok:master Feb 20, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

groupId is int whereas friendId is uint32_t, reason?
2 participants