Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some sizeof tests linux-only. #796

Merged
merged 1 commit into from
Feb 19, 2018
Merged

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Feb 19, 2018

net_crypto has pthread types in its struct, so its size is system
dependent. In particular, the sizes are wrong on FreeBSD.


This change is Reviewable

net_crypto has pthread types in its struct, so its size is system
dependent. In particular, the sizes are wrong on FreeBSD.
@iphydf iphydf added this to the v0.2.0 milestone Feb 19, 2018
@zoff99
Copy link

zoff99 commented Feb 19, 2018

what happens on other systems than linux?


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@zoff99
Copy link

zoff99 commented Feb 19, 2018

:lgtm_strong:


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@iphydf
Copy link
Member Author

iphydf commented Feb 19, 2018

It's a different size on other systems. A bit smaller or larger.

@iphydf iphydf merged commit 097f41f into TokTok:master Feb 19, 2018
@iphydf iphydf deleted the sizeof-pthread branch February 19, 2018 14:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants