Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static asserts for all the struct sizes in toxcore. #778

Merged
merged 1 commit into from
Feb 17, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Feb 14, 2018

This forces us to record size changes (for LP64) and helps estimate
memory consumption of internal data structures.


This change is Reviewable

@iphydf iphydf added this to the v0.2.0 milestone Feb 14, 2018
@iphydf iphydf force-pushed the sizeofs branch 6 times, most recently from 73ec3af to 42b5e14 Compare February 14, 2018 22:52
This forces us to record size changes (for LP64) and helps estimate
memory consumption of internal data structures.
@zoff99
Copy link

zoff99 commented Feb 17, 2018

:lgtm_strong:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@iphydf iphydf merged commit 746c624 into TokTok:master Feb 17, 2018
@iphydf iphydf deleted the sizeofs branch February 17, 2018 17:24
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants