Make cmake script more forgiving. #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iphydf
force-pushed
the
less-cmake-errors
branch
from
17a8e1c
to
76ab292
Compare
|
Reviewed 2 of 2 files at r1. Comments from Reviewable |
iphydf
force-pushed
the
less-cmake-errors
branch
from
76ab292
to
a0ae6aa
Compare
iphydf
force-pushed
the
less-cmake-errors
branch
2 times, most recently
from
38cdcd8
to
3f0d1ac
Compare
Instead of hard-erroring when we don't find dependencies, we just don't build the things requested and print a warning. This is less annoying to users because we enable a bunch of things by default. This way, we can at least build something with the default "cmake" invocation.
|
Reviewed 2 of 2 files at r1. Comments from Reviewable |
|
Review status: 0 of 9 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
|
Reviewed 9 of 9 files at r2. Comments from Reviewable |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
iphydf
force-pushed
the
less-cmake-errors
branch
from
3f0d1ac
to
dcd439a
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hard-erroring when we don't find dependencies, we just don't
build the things requested and print a warning. This is less annoying to
users because we enable a bunch of things by default. This way, we can at
least build something with the default "cmake" invocation.
This change is