Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the markdown GPLv3 license in the c-toxcore repo. #751

Merged
merged 1 commit into from
Feb 8, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Feb 2, 2018

This change is Reviewable

@iphydf iphydf added this to the v0.2.0 milestone Feb 2, 2018
@iphydf iphydf force-pushed the license-md branch 3 times, most recently from 1d81ec7 to 55370fa Compare February 6, 2018 14:36
@iphydf iphydf force-pushed the license-md branch 3 times, most recently from 599b54b to 6c8b1de Compare February 8, 2018 12:02
@robinlinden
Copy link
Member

:lgtm_strong:


Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable


_END OF TERMS AND CONDITIONS_

## How to Apply These Terms to Your New Programs

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess all from that line can be removed as it is useless in our case?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could, but that would constitute a relicensing. We would no longer be using the GPL then. I would like to avoid that.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the license ends at the _END OF TERMS AND CONDITIONS_ line. The following line are just for new projects to start I guess, but I can be wrong, not really a lawyer. x')

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I see what you mean. Yeah, that would be fine, but we use the same LICENSE.md in all repos, and I'd like to add a check that makes sure every repo has a LICENSE.md and that it is the GPL-3.0 one. If we remove that, we should remove it from everywhere. Also, I got this file from here, and I'd like to avoid deviations from that.

@iphydf iphydf merged commit f285793 into TokTok:master Feb 8, 2018
@iphydf iphydf deleted the license-md branch February 8, 2018 17:25
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants