Revert "Add correction message type" #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review status: 0 of 7 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
|
Reviewed 7 of 7 files at r1. Comments from Reviewable |
|
Out of curiosity, why was this reverted? |
|
Same question as @LittleVulpix |
|
@LittleVulpix @SkyzohKey Read discussion in #685 from this comment |
|
Thanks @Diadlo , yeah I think that's fair - though it would have been better if this was linked in the PR summary (instead of just the fact that it's reverting a commit) so that it would be apparent what the motivation was. Still thanks for the explanation! |
|
@LittleVulpix Yes, you are right, I'm sorry |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e16d389 and
commit c5976e3.
This change is