Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add braces to all if statements. #73

Merged
merged 2 commits into from
Aug 31, 2016
Merged

Add braces to all if statements. #73

merged 2 commits into from
Aug 31, 2016

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Aug 30, 2016

Also, removed friends_test, since it's been unused for a long time, and porting it to new internal APIs is not worth it.


This change is Reviewable

@JFreegman
Copy link
Member

:lgtm:


Reviewed 53 of 53 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@nurupo
Copy link
Member

nurupo commented Aug 31, 2016

Reviewed 53 of 53 files at r1.
Review status: all files reviewed at latest revision, 7 unresolved discussions.


testing/DHT_test.c, line 218 [r1] (raw file):

    }

2 many empty lines.


testing/dns3_test.c, line 82 [r1] (raw file):

    uint32_t request_id;

Why empty lines?


testing/irc_syncbot.c, line 151 [r1] (raw file):

            sendbuf[i] = ' ';

        }

Empty lines again.


testing/Messenger_test.c, line 182 [r1] (raw file):

    }

Empty lines.


toxav/video.c, line 149 [r1] (raw file):

    struct RTPMessage *p;

Random new line introduction.


toxcore/Messenger.c, line 1187 [r1] (raw file):

    ft->paused = FILE_PAUSE_NOT;

New lines again.


toxcore/network.c, line 315 [r1] (raw file):

    struct sockaddr_storage addr;

Empty line again.


Comments from Reviewable

@iphydf iphydf force-pushed the braces branch 2 times, most recently from 2e59e73 to bf94fee Compare August 31, 2016 18:12
@iphydf
Copy link
Member Author

iphydf commented Aug 31, 2016

Review status: 41 of 52 files reviewed at latest revision, 7 unresolved discussions.


testing/DHT_test.c, line 218 [r1] (raw file):

Previously, nurupo wrote…

2 many empty lines.

Done.

testing/dns3_test.c, line 82 [r1] (raw file):

Previously, nurupo wrote…

Why empty lines?

Done.

testing/irc_syncbot.c, line 151 [r1] (raw file):

Previously, nurupo wrote…

Empty lines again.

Done.

testing/Messenger_test.c, line 182 [r1] (raw file):

Previously, nurupo wrote…

Empty lines.

Done.

toxav/video.c, line 149 [r1] (raw file):

Previously, nurupo wrote…

Random new line introduction.

Done.

toxcore/Messenger.c, line 1187 [r1] (raw file):

Previously, nurupo wrote…

New lines again.

Done.

toxcore/network.c, line 315 [r1] (raw file):

Previously, nurupo wrote…

Empty line again.

Done.

Comments from Reviewable

@nurupo
Copy link
Member

nurupo commented Aug 31, 2016

:lgtm:


Reviewed 11 of 13 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

We'll revert this once we move to clang-format.
@nurupo
Copy link
Member

nurupo commented Aug 31, 2016

:lgtm:


Reviewed 2 of 13 files at r2, 4 of 4 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@iphydf iphydf closed this Aug 31, 2016
@iphydf iphydf deleted the braces branch August 31, 2016 20:11
@iphydf iphydf merged commit 3a93003 into TokTok:master Aug 31, 2016
@iphydf iphydf modified the milestone: v0.0.1 Nov 6, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants