Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allocate or dereference Tox_Options in tests. #710

Merged
merged 1 commit into from
Jan 21, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 20, 2018

This struct will soon become opaque.


This change is Reviewable

@iphydf iphydf added this to the v0.2.0 milestone Jan 20, 2018
@iphydf iphydf force-pushed the opaque-options branch 2 times, most recently from 3177b52 to 31e6c47 Compare January 21, 2018 00:14
This struct will soon become opaque.
@nurupo
Copy link
Member

nurupo commented Jan 21, 2018

:lgtm_strong:


Reviewed 3 of 3 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@iphydf iphydf merged commit 822dd2f into TokTok:master Jan 21, 2018
@iphydf iphydf deleted the opaque-options branch January 21, 2018 00:50
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants