Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple conference test with 3 friends. #703

Merged
merged 1 commit into from
Jan 20, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 20, 2018

This tests that a message from tox1 is relayed via tox2 to tox3 when tox1
and tox3 are not friends.


This change is Reviewable

@iphydf iphydf added this to the v0.2.0 milestone Jan 20, 2018
@zoff99
Copy link

zoff99 commented Jan 20, 2018

Review status: 0 of 2 files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.


auto_tests/simple_conference_test.c, line 121 at r1 (raw file):

    fprintf(stderr, "Waiting for toxes to come online");

    while (!state1.self_online || !state2.self_online || !state3.self_online) {

loop may never end


auto_tests/simple_conference_test.c, line 135 at r1 (raw file):

    fprintf(stderr, "Waiting for friends to connect");

    while (!state1.friend_online || !state2.friend_online || !state3.friend_online) {

loop may never end


auto_tests/simple_conference_test.c, line 165 at r1 (raw file):

    fprintf(stderr, "Waiting for invitation to arrive");

    while (!state1.joined || !state2.joined || !state3.joined) {

loop may never end


auto_tests/simple_conference_test.c, line 190 at r1 (raw file):

    fprintf(stderr, "Waiting for messages to arrive");

    while (!state2.received || !state3.received) {

loop may never end


Comments from Reviewable

@Diadlo
Copy link

Diadlo commented Jan 20, 2018

@zoff99 Probably, it's right behaviour. Infinity loop will produce timeout error

@iphydf iphydf force-pushed the conference-test branch 2 times, most recently from 36bd568 to 0d2fbe2 Compare January 20, 2018 11:38
@iphydf
Copy link
Member Author

iphydf commented Jan 20, 2018

Correct. Infinite loops are intentional. CTest will kill the test if it times out.

This tests that a message from tox1 is relayed via tox2 to tox3 when tox1
and tox3 are not friends.
@robinlinden
Copy link
Member

:lgtm_strong:


Reviewed 1 of 2 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 4 unresolved discussions.


Comments from Reviewable

@iphydf iphydf merged commit 7c2e4dd into TokTok:master Jan 20, 2018
@iphydf iphydf deleted the conference-test branch January 20, 2018 12:42
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants