Make DHT a module-private type.

[iphydf]

This change is 

[jhert0]

---

Reviewed 15 of 15 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[sudden6]

Reviewed 12 of 15 files at r1.
Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks broke.

---

toxcore/DHT.c, line 131 at r1 (raw file):

const Client_data *dht_get_close_client(const DHT *dht, uint32_t client_num)
{
    return &dht->close_clientlist[client_num];

check for out of bounds read necessary? If not add a comment stating that this function doesn't check bounds

---

toxcore/DHT.c, line 140 at r1 (raw file):

DHT_Friend *dht_get_friend(DHT *dht, uint32_t friend_num)
{
    return &dht->friends_list[friend_num];

same

---

toxcore/DHT.c, line 144 at r1 (raw file):

const uint8_t *dht_get_friend_public_key(const DHT *dht, uint32_t friend_num)
{
    return dht->friends_list[friend_num].public_key;

same

---

toxcore/LAN_discovery.c, line 359 at r1 (raw file):

    char ip_str[IP_NTOA_LEN] = { 0 };
    ip_ntoa(&source.ip, ip_str, sizeof(ip_str));
    LOGGER_DEBUG(dht->log, "Found node in LAN: %s", ip_str);

Intended change or accidentally removed?

---

Comments from Reviewable

[iphydf]

Review status: 12 of 16 files reviewed at latest revision, 4 unresolved discussions, some commit checks pending.

---

toxcore/DHT.c, line 131 at r1 (raw file):

Previously, sudden6 wrote…

check for out of bounds read necessary? If not add a comment stating that this function doesn't check bounds

Added an assert. Proper bound checking can be added later, but it requires the caller to check the return type. In this PR, I'm avoiding logic changes.

---

toxcore/DHT.c, line 140 at r1 (raw file):

Previously, sudden6 wrote…

same

Done.

---

toxcore/DHT.c, line 144 at r1 (raw file):

Previously, sudden6 wrote…

same

Done.

---

toxcore/LAN_discovery.c, line 359 at r1 (raw file):

Previously, sudden6 wrote…

Intended change or accidentally removed?

Intentional, and also removed the filter in auto_tests/helpers.h. Why: because this is complete spam and doesn't help regular debugging at all.

---

Comments from Reviewable

[jhert0]

---

Reviewed 4 of 4 files at r2.
Review status: all files reviewed at latest revision, 4 unresolved discussions.

---

Comments from Reviewable

[sudden6]

---

Review status: 4 of 16 files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable