Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hstox test for now. #686

Merged
merged 1 commit into from
Jan 15, 2018
Merged

Remove hstox test for now. #686

merged 1 commit into from
Jan 15, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 15, 2018

This isn't adding value. We're going to redo the whole rpc test framework
in the future, after a lot of refactoring that the hstox test currently
just stands in the way of.


This change is Reviewable

@iphydf iphydf added this to the v0.2.0 milestone Jan 15, 2018
@jhert0
Copy link
Member

jhert0 commented Jan 15, 2018

:lgtm_strong:


Reviewed 19 of 19 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

This isn't adding value. We're going to redo the whole rpc test framework
in the future, after a lot of refactoring that the hstox test currently
just stands in the way of.
@iphydf iphydf merged commit cec5fea into TokTok:master Jan 15, 2018
@iphydf iphydf deleted the rm-hstox branch January 15, 2018 20:26
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants