Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Onion_Announce a module-private type. #675

Merged
merged 1 commit into from
Jan 14, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 13, 2018

This change is Reviewable

@iphydf iphydf added this to the v0.2.0 milestone Jan 13, 2018
@jhert0
Copy link
Member

jhert0 commented Jan 13, 2018

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks broke.


toxcore/onion_announce.c, line 58 at r1 (raw file):

};

uint8_t *onion_announce_entry_public_key(Onion_Announce *onion_a, uint32_t entry) {

onion_announce_get_entry_public_key


Comments from Reviewable

@iphydf
Copy link
Member Author

iphydf commented Jan 13, 2018

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks broke.


toxcore/onion_announce.c, line 58 at r1 (raw file):

Previously, endoffile78 (Endoffile) wrote…

onion_announce_get_entry_public_key

It's actually a setter in disguise, so calling it "get" would be lying. It can do both. Once we move to apidsl for these files, it'll look different anyway.


Comments from Reviewable

@jhert0
Copy link
Member

jhert0 commented Jan 13, 2018

:lgtm_strong:


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.


Comments from Reviewable

@iphydf iphydf force-pushed the adt-onion-announce branch 4 times, most recently from 9682a5a to e708238 Compare January 14, 2018 11:34
@iphydf iphydf merged commit 4b54d14 into TokTok:master Jan 14, 2018
@iphydf iphydf deleted the adt-onion-announce branch January 14, 2018 15:20
@iphydf iphydf modified the milestones: v0.2.0-RC1, v0.2.0 Jan 14, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants