pkg-config .pc files: added .private versions of Libs and Required #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewed 1 of 1 files at r1. Comments from Reviewable |
To prevent top-level linking of all libraries. Problem: ```pkg-config --libs toxcore``` returns all libraries that are required by all libtox*.so libraries. This is wrong because for a dynamically linked executable only top-level libraries need to be supplied. ```pkg-config --libs --static toxcore``` should return all libraries for the statically linked executable. For example, the ToxBot https://github.com/JFreegman/ToxBot executable uses pkg-config and is linked with the opus library, which is wrong. Based on TokTok#533.
iphydf
force-pushed
the
pkg-config-pc-files
branch
from
e8ec66e
to
1e1efec
Compare
|
@yurivict this means the client build needs to know whether toxcore was built statically. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent top-level linking of all libraries.
Problem:
pkg-config --libs toxcorereturns all libraries that arerequired by all libtox*.so libraries. This is wrong because for a
dynamically linked executable only top-level libraries need to be
supplied.
pkg-config --libs --static toxcoreshould return alllibraries for the statically linked executable.
For example, the ToxBot https://github.com/JFreegman/ToxBot executable
uses pkg-config and is linked with the opus library, which is wrong.
Based on #533.
This change is