Move Networking_Core struct into the .c file. #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without these, we'll have a memory leak on error paths.
These potentially cause uninitialised reads on some platforms or msgpack library versions.
We return E_WRITE because closing only fails when an I/O error occurs, which is likely an error from the write() call above. See close(2) for details. http://man7.org/linux/man-pages/man2/close.2.html
Also replace &(x) with &x for consistency.
This basically means: try until you run out of time (50 minutes on Travis). On Linux, we really want the tests to pass, so there is no point in limiting the number of retries. On windows, we don't retry, on FreeBSD it's limited to 1.
iphydf
force-pushed
the
adt-networking
branch
from
0f5d4dc
to
3e49fec
Compare
|
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 14 of 14 files at r4, 1 of 1 files at r5, 8 of 8 files at r6. toxcore/network.c, line 407 at r6 (raw file):
Wrong indentation. Should be 4 spaces. toxcore/network.c, line 411 at r6 (raw file):
Wrong indentation. Should be 4 spaces. toxcore/network.c, line 843 at r6 (raw file):
Wrong indentation. Should be 4 spaces. Comments from Reviewable |
iphydf
force-pushed
the
adt-networking
branch
from
3e49fec
to
d44feaf
Compare
|
Reviewed 1 of 1 files at r7. Comments from Reviewable |
To make it an abstract type everywhere except in network.c.
iphydf
force-pushed
the
adt-networking
branch
from
d44feaf
to
2fbed5b
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it an abstract type everywhere except in network.c.
This change is