Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable asan, since it seems to break on travis. #661

Merged
merged 1 commit into from
Jan 10, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 10, 2018

But enable it on circle ci, so at least we have one asan build.


This change is Reviewable

@iphydf iphydf added this to the v0.2.0 milestone Jan 10, 2018
@iphydf iphydf force-pushed the disable-asan branch 3 times, most recently from 1e6a183 to 8a797fc Compare January 10, 2018 18:17
But enable it on circle ci, so at least we have one asan build.
@robinlinden
Copy link
Member

:lgtm_strong:


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@robinlinden robinlinden merged commit 6c523f9 into TokTok:master Jan 10, 2018
@iphydf iphydf deleted the disable-asan branch January 10, 2018 20:33
@iphydf iphydf modified the milestones: v0.2.0-RC1, v0.2.0 Jan 14, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants