Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lift libconfig to v1.7.1 #632

Merged
merged 2 commits into from
Dec 14, 2017
Merged

Conversation

robinlinden
Copy link
Member

@robinlinden robinlinden commented Dec 9, 2017

https://github.com/hyperrealm/libconfig has deleted the branches for releases and switched to using tags instead, so the previous method of choosing a release is now broken.


This change is Reviewable

@Diadlo
Copy link

Diadlo commented Dec 9, 2017

Probably --depth=1 is more optimal then --single-branch

@robinlinden
Copy link
Member Author

@Diadlo Whoops. You're right. Fixed, and thank you. :)

@redmanmale
Copy link

:lgtm:


Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@Diadlo
Copy link

Diadlo commented Dec 9, 2017

:lgtm_strong:


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.


Comments from Reviewable

@SkyzohKey SkyzohKey added packaging Packaging P1 High priority PR:ready labels Dec 12, 2017
@robinlinden robinlinden merged commit de27676 into TokTok:master Dec 14, 2017
@robinlinden robinlinden deleted the update-libconfig branch December 14, 2017 21:21
@robinlinden robinlinden added this to the v0.1.11 milestone Dec 14, 2017
@robinlinden
Copy link
Member Author

Merged in #635 as Travis required several of the open PRs to pass and I'm unable to merge anything without Travis passing.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority packaging Packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants