Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.1.10 #575

Merged
merged 1 commit into from
Aug 16, 2017
Merged

Release v0.1.10 #575

merged 1 commit into from
Aug 16, 2017

Conversation

robinlinden
Copy link
Member

@robinlinden robinlinden commented Aug 6, 2017

This change is Reviewable

@robinlinden robinlinden added this to the v0.1.10 milestone Aug 6, 2017
@thierry-FreeBSD
Copy link

Compilation still aborts on FreeBSD:

/usr/local/libexec/ccache/cc  -I/usr/local/include -I/usr/local/include/opus -I/usr/local/include/opencv -O2 -pipe  -fstack-protector -fno-strict-aliasing -std=c99 -pedantic -Wall -Wextra -Weverything -Wno-cast-align -Wno-conversion -Wno-covered-switch-default -Wno-disabled-macro-expansion -Wno-documentation-deprecated-sync -Wno-format-nonliteral -Wno-missing-field-initializers -Wno-missing-prototypes -Wno-padded -Wno-parentheses -Wno-return-type -Wno-sign-compare -Wno-sign-conversion -Wno-tautological-constant-out-of-range-compare -Wno-type-limits -Wno-undef -Wno-unreachable-code -Wno-unused-macros -Wno-unused-parameter -Wno-vla -Wno-assign-enum -Wno-bad-function-cast -Wno-double-promotion -Wno-gnu-zero-variadic-macro-arguments -Wno-packed -Wno-reserved-id-macro -Wno-shadow -Wno-shorten-64-to-32 -Wno-unreachable-code-return -Wno-used-but-marked-unused -isystem /usr/local/include -isystem /usr/local/include/opus -isystem /usr/local/include -isystem /usr/local/include -isystem /usr/local/include -isystem /usr/local/include -isystem /usr/local/include -isystem /usr/local/include -isystem /usr/local/include -O2 -pipe  -fstack-protector -fno-strict-aliasing -MD -MT CMakeFiles/toxcore-sut.dir/testing/hstox/driver.c.o -MF CMakeFiles/toxcore-sut.dir/testing/hstox/driver.c.o.d -o CMakeFiles/toxcore-sut.dir/testing/hstox/driver.c.o   -c testing/hstox/driver.c
testing/hstox/driver.c:229:24: error: variable has incomplete type 'struct sockaddr_in'
    struct sockaddr_in servaddr;
                       ^
testing/hstox/driver.c:229:12: note: forward declaration of 'struct sockaddr_in'
    struct sockaddr_in servaddr;
           ^
testing/hstox/driver.c:231:38: error: use of undeclared identifier 'INADDR_ANY'
    servaddr.sin_addr.s_addr = htons(INADDR_ANY);
                                     ^
testing/hstox/driver.c:231:38: error: use of undeclared identifier 'INADDR_ANY'
testing/hstox/driver.c:231:38: error: use of undeclared identifier 'INADDR_ANY'
testing/hstox/driver.c:231:38: error: use of undeclared identifier 'INADDR_ANY'
5 errors generated.
ninja: build stopped: subcommand failed.
*** Error code 1

@sudden6
Copy link

sudden6 commented Aug 7, 2017

Builds fine on OpenSUSE Leap 42.3 and seems to work fine with qTox 1.11

@nurupo
Copy link
Member

nurupo commented Aug 15, 2017

@thierry-FreeBSD it doesn't include the FreeBSD fixes from #505. Once those are included (in 0.1.11?), it should compile on FreeBSD successfully.

@nurupo
Copy link
Member

nurupo commented Aug 16, 2017

@robinlinden don't forget to to do the thing (#569) after this is merged.

@robinlinden
Copy link
Member Author

robinlinden commented Aug 16, 2017 via email

@sudden6
Copy link

sudden6 commented Aug 16, 2017

:lgtm_strong:


Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@nurupo
Copy link
Member

nurupo commented Aug 16, 2017

I thought you were waiting on @iphy specifically.

Looks good to me. Toxcore master builds on Jenkins and the static code analysis seems good, it gained a couple false positives but that's about it.

:lgtm_strong:


Reviewed 6 of 6 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@robinlinden robinlinden merged commit 6295d28 into TokTok:master Aug 16, 2017
@robinlinden robinlinden deleted the 0.1.10 branch August 16, 2017 19:25
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants