Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fold hstox tests into the general linux test. #555

Merged
merged 1 commit into from
Jun 5, 2017
Merged

Fold hstox tests into the general linux test. #555

merged 1 commit into from
Jun 5, 2017

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jun 4, 2017 •
edited
Loading

We can run the spectest from within cmake, so we should exercise that.

This change is Reviewable

@iphydf iphydf added this to the v0.1.9 milestone Jun 4, 2017
@iphydf iphydf force-pushed the hstox-fold branch 13 times, most recently from 04e6e35 to 0de662e Compare June 5, 2017 14:23
@iphydf
Fold hstox tests into the general linux test.
8479b82 
We can run the spectest from within cmake, so we should exercise that.
@fcore117
Copy link

fcore117 commented Jun 5, 2017

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@robinlinden
Copy link
Member

:lgtm_strong:

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@iphydf iphydf closed this Jun 5, 2017
@iphydf iphydf deleted the hstox-fold branch June 5, 2017 20:31
@iphydf iphydf merged commit 8479b82 into TokTok:master Jun 5, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@iphydf @fcore117 @robinlinden