-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix markdown formatting #534
Conversation
Reviewed 3 of 3 files at r1. INSTALL.md, line 22 at r1 (raw file):
s/ntox/ntox-test-cli Comments from Reviewable |
I put some comments, but they are just about fixing more markdown formatting, nothing about the current state. This is an improvement, so I'm happy after you fix @robinlinden's comment. Review status: all files reviewed at latest revision, 3 unresolved discussions. docs/av_api.md, line 11 at r1 (raw file):
`_listen_port` and the same for all other code fragments in the text. docs/av_api.md, line 16 at r1 (raw file):
Remove space after Comments from Reviewable |
Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed. INSTALL.md, line 22 at r1 (raw file): Previously, robinlinden (Robin Lindén) wrote…
Nice catch. docs/av_api.md, line 11 at r1 (raw file): Previously, iphydf wrote…
In this PR I aim to fix markdown files that have rendered correctly before but because of GitHub changing its markdown parser no longer render correctly. Changes like the one you ask me here are out of scope of what I want to do in this PR. Comments from Reviewable |
a946d45
to
2090ecd
Compare
Review status: 2 of 3 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed. INSTALL.md, line 22 at r1 (raw file): Previously, nurupo wrote…
Should be fixed now. Comments from Reviewable |
Reviewed 1 of 1 files at r2. Comments from Reviewable |
@nurupo, can you rebase and merge? You have merge rights, so just go ahead (and change the milestone to 0.1.8 if you do it before that's released). |
2090ecd
to
f6285d7
Compare
Rebased. @robinlinden you can merge now! |
GitHub changed how their Markdown parser works in non-backwards-compatible way, breaking custom anchors and
#Headings
(it's now required to have a space after#
).There are lines with
#######
in https://github.com/TokTok/c-toxcore/blob/master/docs/updates/Symmetric-NAT-Transversal.md. Not sure if they were rendered to anything, but they are not being rendered right now, which seems fine to me, so I haven't done anything about them.This change is