Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for DHT pack_nodes and unpack_nodes #512

Merged
merged 2 commits into from
Apr 14, 2017
Merged

Add test for DHT pack_nodes and unpack_nodes #512

merged 2 commits into from
Apr 14, 2017

Conversation

Diadlo
Copy link

@Diadlo Diadlo commented Mar 12, 2017

This change is Reviewable

@Diadlo Diadlo changed the title Add test for DHT pack_nodes and unpack_nodes [WIP] Add test for DHT pack_nodes and unpack_nodes Mar 17, 2017
@Diadlo Diadlo changed the title [WIP] Add test for DHT pack_nodes and unpack_nodes Add test for DHT pack_nodes and unpack_nodes Mar 18, 2017
@iphydf iphydf modified the milestone: v0.1.8 Mar 26, 2017
@iphydf
Copy link
Member

iphydf commented Mar 30, 2017

Please enable the checkbox "Allow edits from maintainers." on the bottom right.

@Diadlo
Copy link
Author

Diadlo commented Mar 31, 2017

Done

@iphydf
Copy link
Member

iphydf commented Apr 12, 2017

Review status: 0 of 2 files reviewed at latest revision, 3 unresolved discussions.


auto_tests/dht_test.c, line 686 at r1 (raw file):

    int unpacked_count = unpack_nodes(nodes_unpacked, size, &processed, data, length, tcp_enabled);
    ck_assert_msg(unpacked_count == size, "Wrong unpack_nodes result");
    ck_assert_msg(processed == packed_size, "unpack_nodes processed not all data");

"unpack_nodes did not process all data"


auto_tests/dht_test.c, line 691 at r1 (raw file):

        const IP_Port *ipp1 = &nodes[i].ip_port;
        const IP_Port *ipp2 = &nodes_unpacked[i].ip_port;
        ck_assert_msg(ip_equal(&ipp1->ip, &ipp2->ip), "Unsucessful ip unpack");

"Unsuccessful" (3 times)


auto_tests/dht_test.c, line 719 at r1 (raw file):

    random_bytes(ip, size);
    ipp->ip.family = family;

Remove empty line.


Comments from Reviewable

@iphydf iphydf self-assigned this Apr 12, 2017
@robinlinden
Copy link
Member

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions.


Comments from Reviewable

@iphydf
Copy link
Member

iphydf commented Apr 12, 2017

:lgtm:


Review status: 0 of 2 files reviewed at latest revision, 3 unresolved discussions.


Comments from Reviewable

@iphydf
Copy link
Member

iphydf commented Apr 12, 2017

:lgtm_strong:


Review status: 0 of 2 files reviewed at latest revision, 3 unresolved discussions.


Comments from Reviewable

@robinlinden
Copy link
Member

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.


Comments from Reviewable

@robinlinden robinlinden merged commit e565523 into TokTok:master Apr 14, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants