Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for title change #506

Merged
merged 1 commit into from
Jun 5, 2017
Merged

Add test case for title change #506

merged 1 commit into from
Jun 5, 2017

Conversation

pranomostro
Copy link

@pranomostro pranomostro commented Mar 9, 2017

When user A changes the title for a conference, the tox_callback_conference_title() is
called for everybody except A. This program tests this case.


This change is Reviewable

@pranomostro pranomostro added CAT:coverage P3 Low priority labels Mar 9, 2017
@pranomostro pranomostro self-assigned this Mar 9, 2017
@Diadlo
Copy link

Diadlo commented Mar 14, 2017

Why new test created instead of adding in conference_test?


Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.


auto_tests/self_conference_title_change_test.c, line 35 at r1 (raw file):

static const char *newtitle = "kitten over darknet";

static void cbtitlechange(Tox *tox, uint32_t conference_number, uint32_t peer_number, uint8_t *title, size_t length,

title should be const. I.e. const uint8_t *title


auto_tests/self_conference_title_change_test.c, line 56 at r1 (raw file):

    t = tox_new(&to, NULL);

    tox_callback_conference_title(t, cbtitlechange);

Forget & before cbtitlechange


Comments from Reviewable

@iphydf iphydf modified the milestone: v0.1.8 Mar 26, 2017
@iphydf
Copy link
Member

iphydf commented Mar 26, 2017

@Diadlo I prefer more self-contained test binaries rather than putting a lot of tests together in one file. It takes a bit more time to run them because they don't share the same tox network context, but they are more self-contained, because they don't share the same tox network context :).

@iphydf iphydf modified the milestones: v0.1.8, v0.1.9 Apr 12, 2017
@iphydf iphydf modified the milestones: v0.1.9, 0.1.10 Jun 3, 2017
@iphydf
Copy link
Member

iphydf commented Jun 4, 2017

Please enable the checkbox "Allow edits from maintainers." on the bottom right.

@iphydf iphydf modified the milestones: v0.1.9, 0.1.10 Jun 4, 2017
@pranomostro
Copy link
Author

Done.

@iphydf
Copy link
Member

iphydf commented Jun 5, 2017

:lgtm_strong:


Review status: 0 of 3 files reviewed at latest revision, 2 unresolved discussions.


Comments from Reviewable

@iphydf iphydf merged commit 7f5b057 into TokTok:master Jun 5, 2017
@pranomostro pranomostro deleted the title_conference_change_self branch June 7, 2017 11:15
@iphydf iphydf added the test Adding missing tests, refactoring tests; no production code change label May 5, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Low priority test Adding missing tests, refactoring tests; no production code change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants