Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: install bootstrapd if it is built #504

Merged
merged 1 commit into from
Mar 26, 2017

Conversation

cebe
Copy link
Member

@cebe cebe commented Mar 7, 2017

if bootstrapd option is enabled the binary should be
installed on make install.


This change is Reviewable

@nurupo
Copy link
Member

nurupo commented Mar 7, 2017

Same should apply for the DHT_bootstrap program.

@cebe
Copy link
Member Author

cebe commented Mar 7, 2017

Same should apply for the DHT_bootstrap program.

could be done, but imo the naming is not good for adding it to /usr/local/bin it should contain tox somehow. e.g. tox-dht-bootstrap

@iphydf iphydf modified the milestone: v0.1.8 Mar 26, 2017
@iphydf
Copy link
Member

iphydf commented Mar 26, 2017

Can you enable the checkbox for collaborator pushes?

if bootstrapd option is enabled the binary should be
installed on `make install`.
@iphydf
Copy link
Member

iphydf commented Mar 26, 2017

:lgtm_strong:


Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@iphydf iphydf merged commit d4414ff into TokTok:master Mar 26, 2017
@cebe cebe deleted the cmake-install-bootstrapd branch March 30, 2017 08:35
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants