Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix network #497

Merged
merged 2 commits into from
Mar 5, 2017
Merged

Fix network #497

merged 2 commits into from
Mar 5, 2017

Conversation

Diadlo
Copy link

@Diadlo Diadlo commented Mar 4, 2017 •
edited by iphydf
Loading

Fix #494
Fix #495

This change is Reviewable

@nurupo
Copy link
Member

nurupo commented Mar 4, 2017

Move 'family' coping after all address checks

copying

@Diadlo
Copy link
Author

Diadlo commented Mar 4, 2017

@nurupo Thanks. Fixed

@nurupo
Copy link
Member

nurupo commented Mar 4, 2017

:lgtm_strong: No more unformatter network code or ASAN complaining about heap buffer overflow in Travis, so it's fixed now.

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

@robinlinden
Copy link
Member

:lgtm_strong:

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.

Comments from Reviewable

@iphydf iphydf merged commit c1e3358 into TokTok:master Mar 5, 2017
@iphydf iphydf added this to the v0.1.7 milestone Mar 5, 2017
@iphydf iphydf mentioned this pull request Mar 5, 2017
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.7
Development

Successfully merging this pull request may close these issues.
4 participants
@Diadlo @nurupo @robinlinden @iphydf