Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android build to CI. #459

Merged
merged 1 commit into from
Jan 24, 2017

Conversation

zoff99
Copy link

@zoff99 zoff99 commented Jan 23, 2017

also include fix for #457


This change is Reviewable

@zoff99
Copy link
Author

zoff99 commented Jan 23, 2017

solves #340

@iphydf iphydf changed the title add Android build to CI Add Android build to CI Jan 24, 2017
@iphydf iphydf changed the title Add Android build to CI Add Android build to CI. Jan 24, 2017
@iphydf
Copy link
Member

iphydf commented Jan 24, 2017

This is insanely ugly, but it seems to work, so :lgtm_strong:. We can clean up this CI script later. Please squash your commits into one.


Review status: 0 of 2 files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@iphydf
Copy link
Member

iphydf commented Jan 24, 2017

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@zoff99
Copy link
Author

zoff99 commented Jan 24, 2017

can u squash em for me please? i checked that checkbox.

@zoff99
Copy link
Author

zoff99 commented Jan 24, 2017

also are you sure about that: EPOLLRDHUP fix? is that working for all platforms?

@iphydf
Copy link
Member

iphydf commented Jan 24, 2017

I am not sure about it, but it seems to work, and we'll replace that with libev at some point anyway, so right now I don't care much.

@zoff99
Copy link
Author

zoff99 commented Jan 24, 2017

@iphydf funny that you call it insanely ugly :-) since those are your EXACT commands :-) (from jvm-toxcore-c repo). just not hidden in perl wrappers.
this way i find easier to understand and comprehend

@iphydf iphydf force-pushed the zoff99/build_android_with_CI_002 branch from c25a379 to 287a29b Compare January 24, 2017 11:47
@iphydf
Copy link
Member

iphydf commented Jan 24, 2017

jvm-toxcore-c scripts are also insanely ugly.

@zoff99
Copy link
Author

zoff99 commented Jan 24, 2017

i am happy they exist

@iphydf iphydf merged commit 287a29b into TokTok:master Jan 24, 2017
@iphydf iphydf modified the milestone: v0.1.6 Jan 28, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants