Generate only one large library "libtoxcore". #442

iphydf · 2017-01-16T22:34:06Z

This library contains all the code for the old libtoxcore, libtoxav,
libtoxdns, and libtoxencryptsave. The build for toxav is still optional,
and disabling it causes libtoxcore to simply not contain those symbols
and the pkg-config file to not include opus and vpx as dependencies.

This change is

cebe · 2017-01-17T04:41:15Z

@iphydf can you explain what you are doing here and why?

iphydf · 2017-01-22T00:26:44Z

@cebe I've added a top level comment to the CMakeLists.txt explaining what it does. Why: avoiding the ABI mess that is toxcore.

robinlinden · 2017-01-27T15:51:45Z

Reviewed 11 of 11 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

SkyzohKey · 2017-02-13T17:04:44Z

Reviewed 11 of 11 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

iphydf · 2017-10-04T16:10:49Z

@zoff99 it's always activated when building with CMake.

zoff99 · 2017-10-04T18:15:02Z

@iphydf making cmake and autotools build even more different is a bad idea.
it will break builds :-(

Diadlo · 2017-10-05T11:51:45Z

@iphydf What if someone wants to link his app without toxav, and simultaneously link with toxav for another app, for example?

iphydf · 2017-11-20T12:27:27Z

@Diadlo do you or someone you know have that use case? Otherwise, YAGNI.

iphydf · 2017-11-20T12:27:50Z

@zoff99 I agree. So after this we should make autotools do the same.

Diadlo · 2017-11-20T14:02:07Z

@iphydf It's just like interface segregation. I just don't understand, why you want to merge all function of public API in one library, if they logically different

iphydf · 2017-12-28T18:43:14Z

@Diadlo I'll happily split it out again if and when toxav does not depend on toxcore internals.

The alternative is to have libraries split along the layer boundaries, so we end up having the many-small-libs situation, which we had before. That has different pros and cons. I hope toxav will eventually become independent of toxcore internals (@mannol has plans for this). At that point, I'd like toxav to be a separate repository, developed independently. In the meantime, the split is headaches for developers for no reason.

iphydf · 2017-12-28T18:52:19Z

Oh, and why that is an alternative: because then toxav can correctly depend on toxnetcrypto and other things it uses. Right now, toxav is lying because it says it only depend on toxcore, while actually it depends on its internals. If we expose the internals correctly (through libraries), we can have everything separated.

robinlinden · 2017-12-28T19:40:06Z

Reviewed 1 of 11 files at r1, 2 of 3 files at r2, 3 of 3 files at r3.
Review status: all files reviewed at latest revision, 6 unresolved discussions, all commit checks successful.

CMakeLists.txt, line 323 at r3 (raw file):

    toxav/video.h)
  target_link_modules(toxav toxgroup ${OPUS_LIBRARIES} ${VPX_LIBRARIES})
  #message("*** toxav_LINK_MODULES: ${toxav_LINK_MODULES}")

This should probably be removed.

CMakeLists.txt, line 359 at r3 (raw file):

# Link it to all dependencies.
foreach(sublib ${toxcore_SUBLIBS})
  #message("*** toxcore_LINK_MODULES += ${${sublib}_LINK_MODULES}  # ${sublib}_LINK_MODULES")

This should probably be removed.

cmake/ModulePackage.cmake, line 154 at r3 (raw file):

  foreach(dep ${ARGN})
    #message("*** Processing dep ${dep} for ${target}")

This should probably be removed.

cmake/ModulePackage.cmake, line 165 at r3 (raw file):

        list(FIND LINK_MODULES ${dep} _index)
        if(_index EQUAL -1)
          #message("*** Adding ${dep} to ${target}_LINK_MODULES.")

This should probably be removed.

cmake/StrictAbi.cmake, line 36 at r3 (raw file):

      OUTPUT_STRIP_TRAILING_WHITESPACE)
    string(REPLACE "\n" ";" sublib_SYMS ${sublib_SYMS})

Stray whitespace.

Comments from Reviewable

This library contains all the code for the old libtoxcore, libtoxav, libtoxdns, and libtoxencryptsave. The build for toxav is still optional, and disabling it causes libtoxcore to simply not contain those symbols and the pkg-config file to not include opus and vpx as dependencies.

iphydf · 2017-12-28T23:01:52Z

Review status: all files reviewed at latest revision, 6 unresolved discussions, all commit checks successful.

CMakeLists.txt, line 386 at r2 (raw file):

Previously, cebe (Carsten Brandt) wrote…

what is this? looks super specific to a certain environment.

It's specific to toktok-stack, which is available to everyone (it's a github repo).

CMakeLists.txt, line 323 at r3 (raw file):