Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license headers and remove redundant file name comment. #431

Merged
merged 1 commit into from
Jan 19, 2017

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 14, 2017

"All rights reserved" was incorrect. The project was licensed under GPL3,
which means a lot of rights are licensed to everybody in the world, i.e.
not reserved to the "Tox Project".


This change is Reviewable

@iphydf iphydf modified the milestone: v0.1.5 Jan 14, 2017
@fcore117
Copy link

Reviewed 90 of 90 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@iphydf iphydf force-pushed the license-headers branch 2 times, most recently from b9f03a0 to 44c36dc Compare January 18, 2017 22:56
@robinlinden
Copy link
Member

:lgtm_strong:


Reviewed 90 of 90 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


toxcore/util.c, line 5 at r1 (raw file):

 *
 * This file is donated to the Tox Project.
 * Copyright 2013  plutooo

You didn't remove this person's name from any other files. Is this intentional?


Comments from Reviewable

"All rights reserved" was incorrect. The project was licensed under GPL3,
which means a lot of rights are licensed to everybody in the world, i.e.
not reserved to the "Tox Project".
@iphydf
Copy link
Member Author

iphydf commented Jan 19, 2017

Review status: 89 of 90 files reviewed at latest revision, 1 unresolved discussion.


toxcore/util.c, line 5 at r1 (raw file):

Previously, robinlinden (Robin Lindén) wrote…

You didn't remove this person's name from any other files. Is this intentional?

No, added back.


Comments from Reviewable

@robinlinden
Copy link
Member

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@iphydf iphydf merged commit 8f96ca6 into TokTok:master Jan 19, 2017
@iphydf iphydf deleted the license-headers branch January 19, 2017 12:35
@nurupo
Copy link
Member

nurupo commented Jan 25, 2017

testing/av_test.c, line 22 at r2 (raw file):

 *   Compile with (Linux only; in newly created directory toxcore/dir_name):
 *   gcc -o av_test ../toxav/av_test.c ../build/.libs/libtox*.a -lopencv_core \
 *   -lopencv_highgui -lopencv_imgproc -lsndfile -pthread -lvpx -lopus -lsodium -lportaudio

Was this intentionally removed?


Comments from Reviewable

@nurupo
Copy link
Member

nurupo commented Jan 25, 2017

toxcore/crypto_core_mem.c, line 21 at r2 (raw file):

#ifdef HAVE_CONFIG_H
#include "config.h"
#endif

Unrelated change.


Comments from Reviewable

@nurupo
Copy link
Member

nurupo commented Jan 25, 2017

toxav/ring_buffer.c, line 4 at r2 (raw file):

 * Copyright © 2016-2017 The TokTok team.
 * Copyright © 2013 Tox project.
 * Copyright © 2013 plutooo

What pluto has to do with toxav?


Comments from Reviewable

@nurupo
Copy link
Member

nurupo commented Jan 25, 2017

toxcore/crypto_core_mem.c, line 21 at r2 (raw file):

Previously, nurupo wrote…

Unrelated change.

There are actually quite of few like this.


Comments from Reviewable

@nurupo
Copy link
Member

nurupo commented Jan 25, 2017

Is the unicode copyright symbol somehow better than (c) or (C)?


Comments from Reviewable

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants