Fix NaCl build: tar was called incorrectly. #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tar -jxf expects a file.
zetok
reviewed
Jan 8, 2017
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| # Also install vanilla NaCl | |||
| [ -f $CACHE_DIR/lib/amd64/libnacl.a ] || { | |||
| curl https://hyperelliptic.org/nacl/nacl-20110221.tar.bz2 | tar -jxf | |||
| curl https://hyperelliptic.org/nacl/nacl-20110221.tar.bz2 | tar jx | |||
There was a problem hiding this comment.
Specifying archive format is not necessary when calling tar.
|
Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion. other/travis/autotools-linux-install, line 7 at r1 (raw file): Previously, zetok wrote…
It is for pipes. It can't infer the format without a filename. Comments from Reviewable |
|
Reviewed 1 of 1 files at r1. Comments from Reviewable |
|
Comments from Reviewable |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tar -jxf expects a file.
This change is