-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify that the pass key new
function can fail.
#409
Conversation
5824cca
to
1cfcda9
Compare
Reviewed 2 of 2 files at r1. Comments from Reviewable |
Reviewed 2 of 2 files at r1. Comments from Reviewable |
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed. toxencryptsave/toxencryptsave.api.h, line 168 at r1 (raw file):
Does it really have to be toxencryptsave/toxencryptsave.api.h, line 204 at r1 (raw file):
Only on allocation failure? Else it would be better to write Comments from Reviewable |
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed. toxencryptsave/toxencryptsave.api.h, line 168 at r1 (raw file): Previously, sudden6 wrote…
Why do you think it would be better? If you pass NULL, but a non-zero length, you indicate that you want the function to read more than 0 bytes from the password, which is invalid. Reading exactly 0 bytes from a NULL pointer is valid. toxencryptsave/toxencryptsave.api.h, line 204 at r1 (raw file): Previously, sudden6 wrote…
Allocation failure is the only possible failure here. The only thing this function will ever do (in this version of the API) is call Comments from Reviewable |
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed. toxencryptsave/toxencryptsave.api.h, line 168 at r1 (raw file): Previously, iphydf wrote…
If the function throws an error when toxencryptsave/toxencryptsave.api.h, line 204 at r1 (raw file): Previously, iphydf wrote…
Removing Comments from Reviewable |
d09e47d
to
3e063ed
Compare
Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions. toxencryptsave/toxencryptsave.api.h, line 168 at r1 (raw file): Previously, sudden6 wrote…
Actually, this is incorrect. I just checked. The API is inconsistent: it returns an error when passphrase is NULL here. toxencryptsave/toxencryptsave.api.h, line 204 at r1 (raw file): Previously, sudden6 wrote…
Clarified. Comments from Reviewable |
Reviewed 2 of 2 files at r2. Comments from Reviewable |
Review status: all files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Reviewed 2 of 2 files at r2. Comments from Reviewable |
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from Reviewable |
Also clarify that passwords can be empty or NULL.
3e063ed
to
6480765
Compare
Comments from Reviewable |
@iphydf you forgot to reword the commit message, it still says
|
This change is