New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 404: semicolon not found #404

Merged

iphydf merged 1 commit into TokTok:master from nurupo:fix-missing-semicolon

Jan 6, 2017

Member

nurupo commented Jan 6, 2017 •

edited

Loading

Found through cppcheck.

This change is

iphydf added this to the v0.1.4 milestone

Member

iphydf commented Jan 6, 2017

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

toxcore/crypto_core_mem.c, line 40 at r1 (raw file):

#else
#ifdef _WIN32
    SecureZeroMemory(pnt, len);

len doesn't exist.

Comments from Reviewable

GrayHatter changed the title ~~Fix missing semicolon~~ Issue 404: semicolon not found


          Fix bad attempt at refactoring

e7270aa

nurupo force-pushed the fix-missing-semicolon branch from f7cefe4 to e7270aa Compare

January 6, 2017 21:33

Member Author

nurupo commented Jan 6, 2017

toxcore/crypto_core_mem.c, line 40 at r1 (raw file):

Previously, iphydf wrote…

len doesn't exist.

Fixed.

Comments from Reviewable

Member Author

nurupo commented Jan 6, 2017

Also fixed the if condition. In libsodium's original code memset_s() is called iff len > 0U, but in ours it was called always.

GrayHatter assigned GrayHatter and iphydf

GrayHatter commented Jan 6, 2017

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

Member

iphydf commented Jan 6, 2017

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

iphydf merged commit e7270aa into TokTok:master

This pull request was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet