Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an OSX build that doesn't run tests. #396

Merged
merged 1 commit into from
Jan 6, 2017

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 5, 2017

This one is not allowed to fail and ensures that toxcore can at least be
built for OSX.


This change is Reviewable

@iphydf iphydf added this to the v0.1.3 milestone Jan 5, 2017
@iphydf iphydf force-pushed the osx-build-only branch 2 times, most recently from 932f9e5 to e6d5941 Compare January 5, 2017 21:52
@iphydf iphydf modified the milestones: v0.1.3, v0.1.4 Jan 5, 2017
@jhert0
Copy link
Member

jhert0 commented Jan 6, 2017

:lgtm_strong:


Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@jhert0 jhert0 self-assigned this Jan 6, 2017
This one is not allowed to fail and ensures that toxcore can at least be
built for OSX.
@iphydf iphydf merged commit 08cd613 into TokTok:master Jan 6, 2017
@nurupo
Copy link
Member

nurupo commented Jan 12, 2017

Now waiting even longer in OS X queue! :P

@nurupo
Copy link
Member

nurupo commented Jan 12, 2017

:lgtm_strong:


Comments from Reviewable

@iphydf iphydf deleted the osx-build-only branch January 21, 2018 10:33
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants