Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that TCP connections aren't dropped in callbacks. #392

Merged
merged 1 commit into from
Jan 11, 2017
Merged

Check that TCP connections aren't dropped in callbacks. #392

merged 1 commit into from
Jan 11, 2017

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 5, 2017 •
edited
Loading

They aren't, but it's unclear whether it's structurally impossible.

This change is Reviewable

@iphydf iphydf added this to the v0.1.4 milestone Jan 5, 2017
@iphydf iphydf force-pushed the tcp-con-assert branch 2 times, most recently from 3626b77 to a8507c7 Compare January 8, 2017 20:17
@robinlinden
Copy link
Member

:lgtm_strong:

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

@iphydf iphydf modified the milestone: v0.1.4 Jan 10, 2017
@iphydf
Check that TCP connections aren't dropped in callbacks.
583d716 
They aren't, but it's unclear whether it's structurally impossible.
@piling
Copy link

piling commented Jan 11, 2017

:lgtm_strong:

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@iphydf iphydf merged commit 583d716 into TokTok:master Jan 11, 2017
@iphydf iphydf mentioned this pull request Jan 11, 2017
Merged
@nurupo
Copy link
Member

nurupo commented Jan 12, 2017

:lgtm_strong:

Comments from Reviewable

@iphydf iphydf deleted the tcp-con-assert branch January 21, 2018 10:34
@iphydf iphydf added refactor Refactoring production code, eg. renaming a variable, not affecting semantics and removed code cleanup labels May 4, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@robinlinden robinlinden

Labels
refactor Refactoring production code, eg. renaming a variable, not affecting semantics
Projects
None yet
Milestone
v0.1.4
Development

Successfully merging this pull request may close these issues.
6 participants
@iphydf @robinlinden @piling @nurupo @GrayHatter @irungentoo