Minor simplification in file_seek code.

[iphydf]

Details in comments.

---

This change is 

[GrayHatter]

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

toxcore/Messenger.c, line 1331 at r1 (raw file):

    }

    uint32_t temp_filenum;

Can we simplify this and remove some duplicated variables?

---

Comments from Reviewable

[Diadlo]

Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

---

toxcore/Messenger.c, line 1331 at r1 (raw file):

Previously, GrayHatter (Gregory Mullen) wrote…

Can we simplify this and remove some duplicated variables?

Agree. We can change current filenumber instead of copying

---

toxcore/Messenger.c, line 1337 at r1 (raw file):

    } else {
        // Not receiving.
        return -4;

What about early break?

if (filenumber < (1 << 16)) {
    // Not receiving
    return -4
}

/* Suggestion:   s/temp_filenum/filenumber/ */
temp_filenum = (filenumber >> 16) - 1; 

---

Comments from Reviewable

[iphydf]

Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

toxcore/Messenger.c, line 1331 at r1 (raw file):

Previously, Diadlo (Polshakov Dmitry) wrote…

Agree. We can change current filenumber instead of copying

It's not safe to do so.

---

toxcore/Messenger.c, line 1337 at r1 (raw file):

Previously, Diadlo (Polshakov Dmitry) wrote…

What about early break?

if (filenumber < (1 << 16)) {
    // Not receiving
    return -4
}

/* Suggestion:   s/temp_filenum/filenumber/ */
temp_filenum = (filenumber >> 16) - 1; 

Done.

---

Comments from Reviewable

[GrayHatter]

---

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

Comments from Reviewable

[Diadlo]

---

Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[robinlinden]

---

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[nurupo]

Huh, that's interesting dead code. Why did @irungentoo add the sending else branch in there if it never sends?

---

Comments from Reviewable