Always kill invalid file transfers when receiving file controls.

[iphydf]

Previously, toxcore would send a kill control to the friend only if the
file control was valid. Determining which file transfer is used does not
depend on the specific file control. We can always kill it in that case.

Also, added some logging for file control logic, since there is no other
feedback on error (failure of the file control handler is swallowed).

---

This change is 

[GrayHatter]

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

---

toxcore/Messenger.c, line 1616 at r1 (raw file):

}

static struct File_Transfers *get_file_transfer(uint8_t receive_send, uint8_t filenumber,

bool outgoing/incoming instead of receive_send?

---

toxcore/Messenger.c, line 1638 at r1 (raw file):

/* return -1 on failure, 0 on success.
 */
static int handle_filecontrol(Messenger *m, int32_t friendnumber, uint8_t receive_send, uint8_t filenumber,

receive_send needs to become a bool.

---

Comments from Reviewable

[iphydf]

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.

---

toxcore/Messenger.c, line 1616 at r1 (raw file):

Previously, GrayHatter (Gregory Mullen) wrote…

bool outgoing/incoming instead of receive_send?

Maybe, but then we should rename it everywhere. Not in this PR.

---

toxcore/Messenger.c, line 1638 at r1 (raw file):

Previously, GrayHatter (Gregory Mullen) wrote…

receive_send needs to become a bool.

Not at this point though. There is nothing before this call that checks whether the value is in [0,1]

---

Comments from Reviewable

[GrayHatter]

I'm not happy with the receive_send name. but this

---

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[robinlinden]

---

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[robinlinden]

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[GrayHatter]

---

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[nurupo]

---

Comments from Reviewable