Try searching for libsodium with pkg-config in ./configure. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iphydf
force-pushed
the
libsodium-pkgconfig
branch
2 times, most recently
from
beca154
to
448142b
Compare
|
configure.ac, line 379 [r1] (raw file):
Not sure why you changed it to a specific condition Comments from Reviewable |
|
Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed. configure.ac, line 379 [r1] (raw file):
|
If libsodium can't be found with PKG_CHECK_MODULES, try AC_CHECK_LIB. If that also fails, abort configure. If a user passes --with-libsodium-libs explicitly, that overrides the pkg-config found location.
iphydf
force-pushed
the
libsodium-pkgconfig
branch
from
448142b
to
2fc5449
Compare
|
Reviewed 2 of 2 files at r1. Comments from Reviewable |
zugz
pushed a commit
to zugz/c-toxcore
that referenced
this pull request
Jan 2, 2018
…x_05 Zoff99/ 0.1.10 2017 video fix 05
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If libsodium can't be found with AC_CHECK_LIB, try PKG_CHECK_MODULES. If that
also fails, abort configure.
This change is