Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSL verification in coveralls. #377

Merged
merged 1 commit into from
Jan 2, 2017
Merged

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 2, 2017

We really don't care about coveralls doing its call to the right server.
The worst that can happen is that someone MITMs our coverage analysis,
which we already don't care about much at this point.


This change is Reviewable

@iphydf iphydf added this to the v0.1.3 milestone Jan 2, 2017
@robinlinden
Copy link
Member

:lgtm_strong:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@GrayHatter
Copy link

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@iphydf iphydf force-pushed the unverified-ssl branch 2 times, most recently from 5a910d7 to 9ea9cee Compare January 2, 2017 23:31
@iphydf iphydf changed the title Ignore SSL warnings in coveralls. Fix SSL verification in coveralls. Jan 2, 2017
@iphydf iphydf merged commit 4e731bb into TokTok:master Jan 2, 2017
@iphydf iphydf deleted the unverified-ssl branch January 2, 2017 23:57
pothitos added a commit to pothitos/naxos that referenced this pull request Mar 2, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants