Avoid array out of bounds read in friend saving.

[iphydf]

Fixes #345.

---

This change is 

[Diadlo]

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

toxcore/Messenger.c, line 2732 at r1 (raw file):

            if (temp.status < 3) {
                memcpy(temp.info, m->friendlist[i].info,
                       MIN(m->friendlist[i].info_size, MIN(SAVED_FRIEND_REQUEST_SIZE, MAX_FRIEND_REQUEST_DATA_SIZE)));

Why not precalculate MIN(SAVED_FRIEND_REQUEST_SIZE, MAX_FRIEND_REQUEST_DATA_SIZE)?
Maybe extract result of MIN(..MIN()) into separate variable? IMO it will make reading easier.

---

Comments from Reviewable

[robinlinden]

---

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable

[nurupo]

---

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

toxcore/Messenger.c, line 2732 at r1 (raw file):

Why not precalculate MIN(SAVED_FRIEND_REQUEST_SIZE, MAX_FRIEND_REQUEST_DATA_SIZE)?

MIN(SAVED_FRIEND_REQUEST_SIZE, MAX_FRIEND_REQUEST_DATA_SIZE) should be precalculated by compiler at compile-time, it's a const expression.

---

Comments from Reviewable

[nurupo]

@iphydf just curious, what's aioobe, the branch name? Array Index Out Off Bounds Error?

[Diadlo]

---

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

toxcore/Messenger.c, line 2732 at r1 (raw file):

Previously, nurupo wrote…

Why not precalculate MIN(SAVED_FRIEND_REQUEST_SIZE, MAX_FRIEND_REQUEST_DATA_SIZE)?

MIN(SAVED_FRIEND_REQUEST_SIZE, MAX_FRIEND_REQUEST_DATA_SIZE) should be precalculated by compiler at compile-time, it's a const expression.

Thanks for explanation

---

Comments from Reviewable

[iphydf]

Yes: https://docs.oracle.com/javase/7/docs/api/java/lang/ArrayIndexOutOfBoundsException.html. There was no exception in C, and ASAN can't catch it, but in Java there would have been an AIOOBE.

---

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

toxcore/Messenger.c, line 2732 at r1 (raw file):

Previously, Diadlo (Polshakov Dmitry) wrote…

Thanks for explanation

Moved it to a variable.

---

Comments from Reviewable