-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test to check if tox_new/tox_kill leaks. #341
Conversation
2405786
to
3daa040
Compare
Reviewed 1 of 2 files at r1. auto_tests/resource_leak_test.c, line 3 at r1 (raw file):
According to _BSD_SOURCE || _SVID_SOURCE ||
(_XOPEN_SOURCE >= 500 ||
_XOPEN_SOURCE && _XOPEN_SOURCE_EXTENDED) &&
!(_POSIX_C_SOURCE >= 200112L || _XOPEN_SOURCE >= 600) Maybe you can check for those macros only one time and define a auto_tests/resource_leak_test.c, line 23 at r1 (raw file):
Same as above, plus why not auto_tests/resource_leak_test.c, line 25 at r1 (raw file):
Why not Comments from Reviewable |
Review status: 1 of 2 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed. auto_tests/resource_leak_test.c, line 3 at r1 (raw file): Previously, Ansa89 wrote…
Done. auto_tests/resource_leak_test.c, line 23 at r1 (raw file): Previously, Ansa89 wrote…
Done. auto_tests/resource_leak_test.c, line 25 at r1 (raw file): Previously, Ansa89 wrote…
Historical reasons. Changed now. Comments from Reviewable |
Review status: 1 of 2 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed. auto_tests/resource_leak_test.c, line 41 at r2 (raw file):
Change to Comments from Reviewable |
Review status: 1 of 2 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed. auto_tests/resource_leak_test.c, line 41 at r2 (raw file): Previously, Ansa89 wrote…
Done. Comments from Reviewable |
Reviewed 1 of 1 files at r3. Comments from Reviewable |
We create and destroy 20k tox instances and run a single tox_iterate on it. This test is not comprehensive, but provides a simple check to see whether the destruction properly cleans up memory and perhaps other resources.
a1a5adb
to
de623f9
Compare
We create and destroy 20k tox instances and run a single tox_iterate on
it. This test is not comprehensive, but provides a simple check to see
whether the destruction properly cleans up memory and perhaps other
resources.
This change is