Strengthen the note about ABI compatibility in tox.h. #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iphydf
force-pushed
the
abi-compat-note
branch
2 times, most recently
from
18667bb
to
1921caf
Compare
|
Reviewed 2 of 2 files at r1. Comments from Reviewable |
|
Review status: Comments from Reviewable |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.We really want to get all clients off this struct. We won't actually remove it until 0.2, but we're going to break ABI compatibility with this in various 0.1.x releases.
iphydf
force-pushed
the
abi-compat-note
branch
from
1921caf
to
bf6db32
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We really want to get all clients off this struct. We won't actually
remove it until 0.2, but we're going to break ABI compatibility with this
in various 0.1.x releases.
This change is