Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.1.0. #316

Merged
merged 1 commit into from
Dec 14, 2016
Merged

Release 0.1.0. #316

merged 1 commit into from
Dec 14, 2016

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Dec 11, 2016

This change is Reviewable

@zetok
Copy link

zetok commented Dec 11, 2016

:lgtm_strong:


Review status: 0 of 4 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@robinlinden
Copy link
Member

:lgtm_strong:


Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@GrayHatter
Copy link

:lgtm_strong:


Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@iphydf iphydf force-pushed the 0.1.0 branch 2 times, most recently from bcb4d7a to ef9f909 Compare December 12, 2016 22:57
@JFreegman
Copy link
Member

:lgtm_strong:


Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@sudden6
Copy link

sudden6 commented Dec 13, 2016

:lgtm_strong:


Review status: 0 of 4 files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@@ -2,7 +2,7 @@
# Process this file with autoconf to produce a configure script.

AC_PREREQ([2.65])
AC_INIT([tox], [0.0.5])
AC_INIT([tox], [0.1.0])
AC_CONFIG_AUX_DIR(configure_aux)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to keep in mind.. if it's the "first" release you can probably leave it at 0:0:0, but make sure not to forget the LIBTOXCORE_LT_VERSION setting in configure.ac in future releases, it defines the library compatibility (this is passed to libtool as parameter) and has influence on the name of the library, i.e. .so.x.y.z, I think cmake also has some setting for this.

@nurupo
Copy link
Member

nurupo commented Dec 14, 2016

Given #325 makes it in, it should be fine. There are also some minor things I commented on in #310 #315.

:lgtm:


Reviewed 3 of 4 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@nurupo
Copy link
Member

nurupo commented Dec 14, 2016

:lgtm_strong:


Reviewed 1 of 1 files at r4.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@iphydf iphydf merged commit 7d2f2e4 into TokTok:master Dec 14, 2016
@iphydf iphydf deleted the 0.1.0 branch December 14, 2016 10:24
@GrayHatter
Copy link

🎉

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants