Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2. Hstox test #30

Merged
merged 1 commit into from
Aug 11, 2016
Merged

2. Hstox test #30

merged 1 commit into from
Aug 11, 2016

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Aug 11, 2016

This change is Reviewable

@iphydf iphydf changed the title Hstox test 2. Hstox test Aug 11, 2016
@iphydf iphydf force-pushed the hstox-test branch 2 times, most recently from 415fe23 to a70abfb Compare August 11, 2016 17:25
@GrayHatter
Copy link

Reviewed 4 of 5 files at r1.
Review status: 4 of 5 files reviewed at latest revision, 1 unresolved discussion.


other/travis/hstox-install, line 19 [r1] (raw file):

# The reason we move source files instead of the whole git root directory is
# that the travis scripts (like this one) need to remain in place.
mv toxcore ../hstox/test/toxcore/toxcore

mv not cp -a ?


Comments from Reviewable

@iphydf
Copy link
Member Author

iphydf commented Aug 11, 2016

Review status: 4 of 5 files reviewed at latest revision, 1 unresolved discussion.


other/travis/hstox-install, line 19 [r1] (raw file):

Previously, GrayHatter (Gregory Mullen) wrote…

mv not cp -a ?

It's faster (O(1)) and there is no reason to keep it in its old place. I agree that the gains of avoiding a copy of 20ish files are minimal, but it doesn't add complexity. I can change it if you feel this is confusing.

Comments from Reviewable

@GrayHatter
Copy link

:lgtm:


Reviewed 1 of 5 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


other/travis/hstox-install, line 19 [r1] (raw file):

Previously, iphydf wrote…

It's faster (O(1)) and there is no reason to keep it in its old place. I agree that the gains of avoiding a copy of 20ish files are minimal, but it doesn't add complexity. I can change it if you feel this is confusing.

LGTM

Comments from Reviewable

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants