Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: event length naming inconsistencies #2732

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

Green-Sky
Copy link
Member

@Green-Sky Green-Sky commented Mar 8, 2024

Also applies to types.

This change is Reviewable

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 72.99%. Comparing base (2457125) to head (0199c0f).

Files Patch % Lines
toxcore/events/group_private_message.c 66.66% 2 Missing ⚠️
toxcore/events/group_message.c 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2732   +/-   ##
=======================================
  Coverage   72.99%   72.99%           
=======================================
  Files         149      149           
  Lines       30516    30516           
=======================================
  Hits        22276    22276           
  Misses       8240     8240           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Green-Sky Green-Sky force-pushed the fix_group_event_size_naming branch 3 times, most recently from 1788d56 to c66099e Compare March 8, 2024 10:48
@Green-Sky Green-Sky changed the title wip: try fix event length naming inconsistencies cleanup: event length naming inconsistencies Mar 8, 2024
@Green-Sky Green-Sky added this to the v0.2.19 milestone Mar 8, 2024
@Green-Sky Green-Sky force-pushed the fix_group_event_size_naming branch from c66099e to 6c340c8 Compare March 8, 2024 10:52
@Green-Sky Green-Sky force-pushed the fix_group_event_size_naming branch from 6c340c8 to 18b870f Compare March 8, 2024 11:22
@Green-Sky Green-Sky marked this pull request as ready for review March 8, 2024 11:22
@Green-Sky Green-Sky force-pushed the fix_group_event_size_naming branch from 18b870f to 93ad4ec Compare March 8, 2024 11:31
Copy link
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 change requests, 1 of 1 approvals obtained (waiting on @Green-Sky)


other/event_tooling/generate_event_c.cpp line 783 at r1 (raw file):

they are :)

kinda makes no sense if you didn't see the original comment


toxcore/events/group_message.c line 257 at r1 (raw file):

void tox_events_handle_group_message(
    Tox *tox, uint32_t group_number, uint32_t peer_id, Tox_Message_Type type, const uint8_t *message, size_t message_length, uint32_t message_id,

message_type?


toxcore/events/group_private_message.c line 257 at r1 (raw file):

void tox_events_handle_group_private_message(
    Tox *tox, uint32_t group_number, uint32_t peer_id, Tox_Message_Type type, const uint8_t *message, size_t message_length, uint32_t message_id,

message_type?

other/event_tooling/generate_event_c.cpp Outdated Show resolved Hide resolved
@pull-request-attention pull-request-attention bot assigned nurupo and unassigned Green-Sky Mar 8, 2024
@Green-Sky Green-Sky force-pushed the fix_group_event_size_naming branch from 93ad4ec to 8163932 Compare March 8, 2024 16:52
@Green-Sky Green-Sky marked this pull request as draft March 8, 2024 16:56
@Green-Sky Green-Sky force-pushed the fix_group_event_size_naming branch from 8163932 to 2048c81 Compare March 8, 2024 17:00
@Green-Sky Green-Sky marked this pull request as ready for review March 8, 2024 17:01
@Green-Sky Green-Sky force-pushed the fix_group_event_size_naming branch from 2048c81 to 87ab6d5 Compare March 8, 2024 17:05
@JFreegman JFreegman requested a review from nurupo March 8, 2024 17:07
Copy link
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @Green-Sky and @nurupo)

@Green-Sky Green-Sky force-pushed the fix_group_event_size_naming branch 2 times, most recently from 9151bcd to 6c1fe91 Compare March 8, 2024 17:11
@Green-Sky Green-Sky force-pushed the fix_group_event_size_naming branch from 6c1fe91 to 0199c0f Compare March 8, 2024 17:15
@Green-Sky Green-Sky merged commit 0199c0f into TokTok:master Mar 8, 2024
60 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants