Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to and from network byte order in set/get nospam. #271

Merged
merged 1 commit into from
Nov 15, 2016

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Nov 14, 2016

Fixes #205.


This change is Reviewable

@iphydf iphydf added this to the v0.0.4 milestone Nov 14, 2016
@nurupo
Copy link
Member

nurupo commented Nov 14, 2016

Does storing the nospam in network byte order internally break anything?
cc @irungentoo


Comments from Reviewable

@GrayHatter
Copy link

:lgtm_strong:


Reviewed 2 of 3 files at r1.
Review status: 2 of 3 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@nurupo
Copy link
Member

nurupo commented Nov 14, 2016

:lgtm_strong:


Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@GrayHatter GrayHatter modified the milestones: v0.0.5, v0.0.4 Nov 14, 2016
@GrayHatter
Copy link

Moved to v0.0.5 -- the review wasn't approved in time.

@iphydf iphydf merged commit 878efdc into TokTok:master Nov 15, 2016
@iphydf iphydf deleted the nospam-htonl branch December 23, 2016 02:30
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants