refactor: Use tox rng to seed the keypair generation. #2671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iphydf
force-pushed
the
rng-sign-keypair
branch
from
dd45166
to
704898e
Compare
iphydf
force-pushed
the
rng-sign-keypair
branch
from
704898e
to
1822488
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2671 +/- ##
==========================================
- Coverage 73.02% 73.02% -0.01%
==========================================
Files 148 148
Lines 30482 30484 +2
==========================================
+ Hits 22261 22262 +1
- Misses 8221 8222 +1 ☔ View full report in Codecov by Sentry. |
iphydf
force-pushed
the
rng-sign-keypair
branch
2 times, most recently
from
d88a13c
to
ac63bce
Compare
|
this makes key generation deterministic. Did you check how the fuzzer behaves with this? |
|
What behaviour do you want me to check regarding the fuzzer? |
|
Sorry, my real question was: "Is this intentional, with all its side effects" :) |
|
Yes, it is intentional to make tests and fuzzers deterministic. |
robinlinden
approved these changes
Feb 11, 2024
iphydf
force-pushed
the
rng-sign-keypair
branch
from
ac63bce
to
ff9c651
Compare
JFreegman
approved these changes
Feb 11, 2024
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 2 of 1 approvals obtained
iphydf
force-pushed
the
rng-sign-keypair
branch
from
ff9c651
to
5d7b7a7
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2649
This change is