Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable -Wunused-but-set-variable compiler warning flag. #265

Merged
merged 1 commit into from
Nov 11, 2016

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Nov 11, 2016

This warning is triggered in av_test.c, where we have an open issue.
Silencing the warning locally would make the issue less visible. This
way, we will see the warning when we start removing the -Wno-* flags.


This change is Reviewable

@iphydf iphydf added this to the v0.0.4 milestone Nov 11, 2016
@iphydf
Copy link
Member Author

iphydf commented Nov 11, 2016

@Mikhael-Danilov this should solve the -Werror issue without introducing nop-code that hides the actual issue.

@robinlinden
Copy link
Member

:lgtm_strong:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@GrayHatter
Copy link

:lgtm_strong:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

This warning is triggered in `av_test.c`, where we have an open issue.
Silencing the warning locally would make the issue less visible. This
way, we will see the warning when we start removing the `-Wno-*` flags.
@iphydf iphydf merged commit a205b78 into TokTok:master Nov 11, 2016
@iphydf iphydf deleted the no-warn branch December 23, 2016 02:31
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants