Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Further #include cleanups. #2617

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 31, 2024

This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Jan 31, 2024
@iphydf iphydf marked this pull request as ready for review January 31, 2024 14:00
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8d29935) 73.65% compared to head (0c05566) 73.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2617      +/-   ##
==========================================
+ Coverage   73.65%   73.74%   +0.08%     
==========================================
  Files         148      148              
  Lines       30407    30407              
==========================================
+ Hits        22396    22423      +27     
+ Misses       8011     7984      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf force-pushed the test-includes branch 3 times, most recently from 3cb28e4 to 21b2a6e Compare January 31, 2024 20:41
Copy link
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@toktok-releaser toktok-releaser merged commit 0c05566 into TokTok:master Jan 31, 2024
58 checks passed
@iphydf iphydf deleted the test-includes branch January 31, 2024 22:35
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants