Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: Use Bazel modules to enforce proper #include hygiene. #2614

Merged
merged 1 commit into from
Jan 31, 2024
Merged

cleanup: Use Bazel modules to enforce proper #include hygiene. #2614

merged 1 commit into from
Jan 31, 2024

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 30, 2024 •
edited
Loading

This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Jan 30, 2024
@nurupo
Copy link
Member

nurupo commented Jan 30, 2024

"cleanup: Use Bazel modules to enforce proper #include hygiene"?

@codecov Codecov
Copy link

codecov bot commented Jan 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1710a0d) 73.61% compared to head (511bfe3) 73.67%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2614      +/-   ##
==========================================
+ Coverage   73.61%   73.67%   +0.05%     
==========================================
  Files         148      148              
  Lines       30407    30407              
==========================================
+ Hits        22385    22401      +16     
+ Misses       8022     8006      -16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf force-pushed the modules branch 2 times, most recently from 990dd17 to 2f18bc2 Compare January 30, 2024 23:11
@iphydf iphydf changed the title cleanup: Use C++ modules to enforce proper #include hygiene. cleanup: Use Bazel modules to enforce proper #include hygiene. Jan 30, 2024
@iphydf
Copy link
Member Author

iphydf commented Jan 30, 2024

If people are so confused about -fimplicit-module-maps and -fmodule-map-file, then ok. I've renamed the PR even though it's not using anything from bazel, it only uses the BUILD file for information on how to structure the modulemap.

@restyled-io restyled-io bot mentioned this pull request Jan 30, 2024
Closed
@iphydf iphydf force-pushed the modules branch 2 times, most recently from 6875ee7 to 8fe2fba Compare January 30, 2024 23:25
@restyled-io restyled-io bot mentioned this pull request Jan 30, 2024
Closed
@iphydf iphydf marked this pull request as ready for review January 30, 2024 23:30
@iphydf iphydf requested a review from a team as a code owner January 30, 2024 23:30
@toktok-releaser toktok-releaser merged commit 511bfe3 into TokTok:master Jan 31, 2024
59 checks passed
@iphydf iphydf deleted the modules branch January 31, 2024 00:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinlinden robinlinden robinlinden approved these changes

Assignees

@iphydf iphydf

Labels
None yet
Projects
None yet
Milestone
v0.2.19
Development

Successfully merging this pull request may close these issues.
4 participants
@iphydf @nurupo @robinlinden @toktok-releaser