Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rename system_{memory,...} to os_{memory,...}. #2598

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 25, 2024

This rename happens in the system PR, so I'm pulling it out to reduce the size of that PR.


This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Jan 25, 2024
@iphydf iphydf marked this pull request as ready for review January 25, 2024 12:57
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (203e1af) 73.66% compared to head (bdf460a) 73.76%.

Files Patch % Lines
toxcore/network.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2598      +/-   ##
==========================================
+ Coverage   73.66%   73.76%   +0.10%     
==========================================
  Files         148      148              
  Lines       30373    30373              
==========================================
+ Hits        22374    22405      +31     
+ Misses       7999     7968      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 33 of 33 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

This rename happens in the system PR, so I'm pulling it out to reduce
the size of that PR.
@iphydf iphydf changed the title refactor: Rename system_{memory,...} to os_{memory,...}. refactor: Rename system_{memory,...} to os_{memory,...} Jan 25, 2024
@iphydf iphydf changed the title refactor: Rename system_{memory,...} to os_{memory,...} refactor: Rename system_{memory,...} to os_{memory,...}. Jan 25, 2024
@toktok-releaser toktok-releaser merged commit bdf460a into TokTok:master Jan 25, 2024
57 checks passed
@iphydf iphydf deleted the os-sys branch January 25, 2024 21:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants